PR followup for os.h false linter errors #2370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielaE
reviewed
Jun 21, 2021
Contributor
DanielaE
left a comment
There was a problem hiding this comment.
I suggest to squash all three commits into one to keep history clean.
Contributor
Author
|
Thanks for the suggestion @DanielaE - I have squashed the commits together. |
vitaut
reviewed
Jun 26, 2021
include/fmt/core.h
Outdated
|
|
||
| #if defined(__has_include) && !defined(__INTELLISENSE__) && \ | ||
| #if defined(__has_include) && \ | ||
| (!defined(__INTELLISENSE__) || (!FMT_MSC_VER || FMT_MSC_VER > 1900)) && \ |
Contributor
There was a problem hiding this comment.
I don't think we need the !FMT_MSC_VER check here because it will be covered by !defined(__INTELLISENSE__).
Contributor
Author
There was a problem hiding this comment.
You are right, !FMT_MSC_VER is a redundant check. I have removed it.
Adjust definition for FMT_HAS_INCLUDE Remove check for `!FMT_MSC_VER`
Contributor
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes proposed in issue #2368.