Introduced NamedArgWithType<Char, T> : NamedArg<Char> #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I found that if I put custom type as a named argument it is impossible to get its size in variadic functions:
template < typename Char >
void serialize(Buffer &buffer, const fmt::internal::NamedArg< Char >& arg) {
// serialize named argument
}
So I extend fmt::internal::NamedArg with no overhead:
template < typename Char, typename T >
struct NamedArgWithType : NamedArg< Char > {
NamedArgWithType(BasicStringRef< Char > argname, const T &value)
: NamedArg< Char >(argname, value) {}
};
With this fix I was able to cover all args serializaton/deserializaton for base and trivially copyable types.
Hope you'll accept this PR as well! Thanks in advance!