Add per-widget configuration#885
Merged
Merged
Conversation
Collaborator
Author
|
However, because the original settings keys are now treated as the default widget settings, this means existing users would have no means to restore the 'factory' defaults. Easy way around this is to expose a |
Collaborator
Author
|
Widget config dialogs now expose 3 actions from the
|
And move appearance tab ahead of general
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a shared per-widget configuration for most layout widgets.
Each widget now has a
Configure...action in its instance context menu, opening a widget-specific config dialog. Widget instance state is now serialised into the layout file, so configuration is restored per instance when a layout is loaded.As part of this change, widget options that were previously only available through global settings pages have been moved into per-widget configuration where appropriate. The corresponding global settings pages have been removed, except in cases where the underlying state remains genuinely global or shared across multiple widget instances.
Default configuration for newly created widget instances remains persisted through the existing settings store and keys. The config dialogs provide a
Save as defaultaction, which writes the current dialog state back to those stored defaults without affecting already-configured widget instances.In addition to the above, all settings which did not make use of
subscribehave been demoted to unregistered settings, after which they must usefileValueandfileSetinstead.Addresses #843