[core,gui] Multiple fixes to "Stop after this"#923
Merged
Conversation
ludouzi
requested changes
Mar 24, 2026
ludouzi
approved these changes
Mar 25, 2026
ludouzi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! All works fine now after testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are three fixes for "Stop after this", split into individual commits for clarity.
First commit fixes the Stop icon not showing due to a bad comparison, second commit fixes syncing on model reset or playlist change, third commit ensures we unset "Stop after current" when a different track is selected for "Stop after this".