Skip to content

[filters] Add option to change cover source preference#1111

Merged
ludouzi merged 6 commits into
fooyin:masterfrom
lstrsrt:filters-cover-source
May 5, 2026
Merged

[filters] Add option to change cover source preference#1111
ludouzi merged 6 commits into
fooyin:masterfrom
lstrsrt:filters-cover-source

Conversation

@lstrsrt

@lstrsrt lstrsrt commented May 4, 2026

Copy link
Copy Markdown
Contributor

This adds a filters context menu option (Filter options > Display) to override the artwork local source preference from the global settings. I did this by first adding a setSourcePreference function to CoverProvider and then wiring it up to the filter model.

Additionally:

  • Fix a misspelled variable name.
  • Pass CoverLoader by reference in some CoverProvider-internal functions.

Closes #1021.

Comment thread include/gui/coverprovider.h
Comment thread src/plugins/filters/filtermodel.cpp
Comment thread src/plugins/filters/filterwidget.h Outdated
Comment thread src/plugins/filters/filterwidget.cpp Outdated

@ludouzi ludouzi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ludouzi ludouzi merged commit 8a159ea into fooyin:master May 5, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Album Art…Sort Of

2 participants