fix(lsp): support mixed encoding for lsp clients#1004
Merged
Conversation
folke
requested changes
Nov 26, 2024
Owner
folke
left a comment
There was a problem hiding this comment.
Apart from the availability of vim.lsp.protocol, I also don't think passing a function as params works on Neovim <= 0.9?
Contributor
Author
|
I didn't read the README properly I had always assumed noice was nightly only, not nightly recommended I can add a shim for back compat this evening |
729baaa to
c85d738
Compare
c85d738 to
163d8e3
Compare
Contributor
Author
|
Added a shim, and removed the reference to |
folke
approved these changes
Nov 26, 2024
Owner
|
ty! |
|
Thanks @tris203 for figuring this out, looking forward to the 4.8.0 release in order to get rid of the |
folke
pushed a commit
that referenced
this pull request
Dec 7, 2024
🤖 I have created a release *beep* *boop* --- ## [4.8.0](v4.7.2...v4.8.0) (2024-12-06) ### Features * **msg:** added support for msg_show list_cmd and input_prompt kinds ([21fe733](21fe733)) ### Bug Fixes * **cmdline:** dont restore cursor after render. Fixes [#959](#959) ([c49a4b0](c49a4b0)) * **health:** better health checks ([0f5f8c9](0f5f8c9)) * **lsp:** support mixed encoding for lsp clients ([#1004](#1004)) ([c6f6fb1](c6f6fb1)) * **msg:** add new msg_show.lua_print to default routes for messages ([0e9853b](0e9853b)) * **notify:** always convert msg to string if not nil and not string ([3efadda](3efadda)) * **nui:** set max size to editor cols ([d9991ca](d9991ca)) * **router:** prevent overriding current tick ([e0fd746](e0fd746)) * **ui:** always queue incoming events when already processing ([6c7545a](6c7545a)) ### Performance Improvements * **hacks:** disable redraw hack. Should not be needed. If it breaks a plugin, then it should be fixed there. ([956e3ac](956e3ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a warning notification for the first hover/signature help notification on nightly now that
offset_encodingis required formake_position_params