Feat: mTLS support#26
Merged
Merged
Conversation
Cleanup & Updown Script
Fix 51820 typo
Member
|
This is an awesome addition thank you for taking the time to work on this! I was just trying to test and want to just make sure I understand something: if I do not make any change to the traefik config it still seems to work and connect. Is this expected? Like my config is just stock with no cert defined. |
oschwartz10612
requested changes
Apr 2, 2025
…duplicates, handling null-pointer case and some logging
Contributor
Author
|
Added one, not feature related fix: at the end of |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
This PR adds basic support for connecting to servers requiring a client certificate, aka mTLS.
Some restrictions for now (all documented):
How to test?
I am planning on a PR against the pangolin repo too with similar contents, but first,
newt:)(This was tested only on macos so far)
Positive test
self-signed-certs-for-mtls.shdynamic_config.yamlby adding the followingalice-at-example-com.eng.12to your clientGet InfoTrustSSLtoAlways Trust--tls-client-cert=./certs/clients/alice-at-example-com.p12Negative test
--tls-client-cert=...arg.