-
Notifications
You must be signed in to change notification settings - Fork 179
Pr 891 #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr 891 #897
Conversation
Adapted to use IDF4-style RMT function API (driver/rmt.h) so it compiles with platform-espressif32 @ 6.12.0 and runs on ESP32-S3 without direct register access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are significant architectural changes here that need to be discussed. The actual changes needed to support S3 and other advanced CPUs is a much simpler set of changes. The real issue is an instability in the WiFi code in the latest images.
You can reach me on discord and set up a call. MartinMueller2003 is my discord handle.
| <div class="col-sm-4"> | ||
| <input type="number" class="form-control is-valid" id="miso_pin" step="1" min="0" | ||
| max="40" value="0" required title="GPIO on which MISO will be received"> | ||
| max="50" value="0" required title="GPIO on which MISO will be received"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This max value is CPU / Platform dependant. You should leave it alone here and change the script.js file to detect get the limit from the config file. Same for all of the IO max settings.
| */ | ||
|
|
||
| //Output Manager | ||
| #define DEFAULT_RMT_0_GPIO gpio_num_t::GPIO_NUM_1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not valid. The S3 only supports 4 TX capable RMT channels.
| ;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~; | ||
| [esp32] | ||
| platform = espressif32 @ ^6.10.0 | ||
| platform = espressif32 @ ^6.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this on the other platforms? This failed in my most recent tests.
| -D BOARD_SEEED_XIAO_ESP32S3 | ||
| -D ARDUINO_USB_CDC_ON_BOOT=1 | ||
|
|
||
| build_unflags = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to disable the PSRAM. It causes issues in the output channel.
|
|
||
| bool ret = true; | ||
| DisableUartInterrupts(); | ||
| #if defined(ARDUINO_ARCH_ESP8266) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can actually be done by changing a single line.
src/output/OutputRmt.cpp
Outdated
| * damages in connection with, or arising out of, the furnishing, performance | ||
| * or use of these programs. | ||
| * | ||
| * Adapted to use IDF4-style RMT function API (driver/rmt.h) so it compiles with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Direct register access was used to improve performance. This is an architectural difference. Please contact me on Discord so we can discuss and look at how you tested this.
This commit adds support for receiving E1.31 data over ESP-NOW. A new 'ESP-NOW' tab has been added to the web interface to allow for enabling/disabling the feature and configuring the Wi-Fi channel. When ESP-NOW is enabled, it has priority over other Wi-Fi inputs. Data received via ESP-NOW is processed by the FPP daemon.
This commit fixes a critical bug that caused a `LoadProhibited` crash on startup. The `isESPNOWActive` function was incorrectly using an integer ID as a pointer, leading to a null pointer dereference. This has been corrected to use the proper `InputDriver` pointer, which resolves the crash.
Feature: ESP-NOW Support
- Updated `src/FileMgr.cpp` to call `LittleFS.begin(true)`. - This ensures the filesystem is automatically formatted if it fails to mount, allowing the device to recover after a full chip erase.
No description provided.