Skip to content

Switch to version of grol and indirectly terminal without dep cycle (and dflag/scli with latest version too) #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ldemailly merged 1 commit into from
Apr 8, 2025
Merged

Switch to version of grol and indirectly terminal without dep cycle (and dflag/scli with latest version too) #1035

ldemailly merged 1 commit into from
Apr 8, 2025

Conversation

@ldemailly
Copy link
Member

@ldemailly ldemailly commented Apr 8, 2025 •
edited
Loading

before:

image

after/now:

go mod graph | awk '$1 ~ /^(fortio\.org|grol\.io)/ && $2 ~ /^(fortio\.org|grol\.io)/' | modgv | dot -Tpng -o mod-deps.png

image

@ldemailly ldemailly changed the title Switch to version of grol and indirectly terminal and dflag/scli with… Switch to version of grol and indirectly terminal and dflag/scli with latest version Apr 8, 2025
@ldemailly ldemailly requested a review from asha-oss April 8, 2025 02:41
@ldemailly ldemailly changed the title Switch to version of grol and indirectly terminal and dflag/scli with latest version Switch to version of grol and indirectly terminal without dep cycle (and dflag/scli with latest version too) Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0%. Comparing base (bb77a72) to head (86fc098).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #1035   +/-   ##
======================================
  Coverage    74.0%   74.0%           
======================================
  Files          26      26           
  Lines        6398    6398           
======================================
  Hits         4736    4736           
  Misses       1477    1477           
  Partials      185     185

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ldemailly ldemailly merged commit 6d7bf74 into master Apr 8, 2025
10 checks passed
@ldemailly ldemailly deleted the dep_cycle branch April 8, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asha-oss asha-oss asha-oss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ldemailly @asha-oss