Skip to content

Get latest safecast: use int based MustConv instead of MustConvert #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ldemailly merged 1 commit into from
Aug 30, 2025
Merged

Get latest safecast: use int based MustConv instead of MustConvert #1086

ldemailly merged 1 commit into from
Aug 30, 2025

Conversation

@ldemailly
Copy link
Member

@ldemailly ldemailly commented Aug 30, 2025

and prep for release

@ldemailly ldemailly requested a review from asha-oss August 30, 2025 00:02
@ldemailly ldemailly marked this pull request as ready for review August 30, 2025 00:04
@ldemailly ldemailly merged commit 2f4a48e into master Aug 30, 2025
8 checks passed
@ldemailly ldemailly deleted the newest_safecast branch August 30, 2025 00:05
@codecov
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.1%. Comparing base (06219bd) to head (94bb3a3).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
fhttp/http_client.go 81.2% 2 Missing and 1 partial ⚠️
bincommon/commonflags.go 0.0% 2 Missing ⚠️
cli/fortio_main.go 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #1086   +/-   ##
======================================
  Coverage    70.1%   70.1%           
======================================
  Files          27      27           
  Lines        6530    6530           
======================================
  Hits         4575    4575           
  Misses       1800    1800           
  Partials      155     155

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asha-oss asha-oss asha-oss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ldemailly @asha-oss