Skip to content

Show dest ip #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andraxylia merged 4 commits into from
Apr 25, 2018
Merged

Show dest ip #236

andraxylia merged 4 commits into from
Apr 25, 2018

Conversation

@ldemailly
Copy link
Member

@ldemailly ldemailly commented Apr 24, 2018

Eg.

15:25:37 V network.go:148> Proxy: Accepted proxy connection from
100.123.127.245:59765 -> 100.123.127.245:8088 (for [::1]:8080)

@ldemailly
Allow disabled for grpc port too to skip without printing an error
0e3fda9 
So this works without spurious output:
```
$ fortio server --quiet --redirect-port "disabled" --grpc-port
"disabled" -http-port 0 -ui-path "" | awk '{print $7}'
[::]:64474
```

Manually tested
@ldemailly
Make linter happy + update readme
f47484e
@ldemailly
Merge branch 'master' into show_dest_ip
95167a3
@ldemailly
Show destination IP in tcp proxy connections in verbose mode
58c5545 
Eg.
```
15:25:37 V network.go:148> Proxy: Accepted proxy connection from
100.123.127.245:59765 -> 100.123.127.245:8088 (for [::1]:8080)
```
@codecov
Copy link

codecov bot commented Apr 24, 2018 •
edited
Loading

Codecov Report

Merging #236 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #236     +/-   ##
========================================
+ Coverage    90.2%   90.4%   +0.2%     
========================================
  Files          10      10             
  Lines        1883    1872     -11     
========================================
- Hits         1699    1693      -6     
+ Misses        118     115      -3     
+ Partials       66      64      -2
Impacted Files Coverage Δ
fnet/network.go 94.3% <100%> (+0.1%) ⬆️
fgrpc/grpcrunner.go 88.3% <0%> (+0.5%) ⬆️
fgrpc/pingsrv.go 91.7% <0%> (+4.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca55ae7...58c5545. Read the comment docs.

@ldemailly ldemailly requested a review from andraxylia April 25, 2018 00:53
@ldemailly
Copy link
Member Author

ldemailly commented Apr 25, 2018

@andraxylia this helps show which IP is used as destination as seen by receiving end
(and shows I was wrong about cluster ip vs pod ip! my bad!), ptal

@andraxylia andraxylia merged commit 4adea0b into master Apr 25, 2018
@ldemailly ldemailly deleted the show_dest_ip branch April 25, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andraxylia andraxylia andraxylia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ldemailly @andraxylia