Skip to content

Conversation

@ldemailly
Copy link
Member

Avoids security error on https://istio.io/

@istio-testing
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ldemailly
Copy link
Member Author

#287 will cleanup to copy pasta/duplication in those 3 files

@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #286 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #286     +/-   ##
=======================================
+ Coverage    90.8%    91%   +0.2%     
=======================================
  Files          10     10             
  Lines        2059   2022     -37     
=======================================
- Hits         1870   1841     -29     
+ Misses        123    119      -4     
+ Partials       66     62      -4
Impacted Files Coverage Δ
fgrpc/pingsrv.go 94.4% <0%> (+5.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da08627...59309de. Read the comment docs.

@ldemailly ldemailly requested a review from olimpias August 21, 2018 21:33
@ldemailly ldemailly merged commit 7a51259 into master Aug 21, 2018
@ldemailly ldemailly deleted the https_fix branch August 21, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants