Use zerolog + intercept SIGINT #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @VaiTon, Thanks for the nice additions! Is it possible to change the timestamp format of zerolog to ISO format? now it logs only time and in am/pm notation. |
Contributor
Author
|
@yunzheng done! :) |
Member
|
Thanks, looks much better :) Can you also update the README.md with the new --help output as Also found a small issue, if the command failed to run (eg permission not denied) I cannot CTRL+C it. $ ./pcap-broker -cmd 'tcpdump -i eth0 -n --immediate-mode -s 65535 -U -w -'
2023-12-11T14:33:41Z ??? tcpdump: eth0: You don't have permission to capture on that device
(socket: Operation not permitted)
^C
<-- hangs here -->Before it would just exit by default: $ ./pcap-broker-orig -cmd 'tcpdump -i eth0 -n --immediate-mode -s 65535 -U -w -'
2023/12/11 14:34:23 config PCAP_COMMAND = "tcpdump -i eth0 -n --immediate-mode -s 65535 -U -w -"
2023/12/11 14:34:23 config LISTEN_ADDRESS = "localhost:4242"
2023/12/11 14:34:23 cmd = [tcpdump -i eth0 -n --immediate-mode -s 65535 -U -w -]
2023/12/11 14:34:23 PID 8837
tcpdump: eth0: You don't have permission to capture on that device
(socket: Operation not permitted)
2023/12/11 14:34:23 Process exited with error: exit status 1 |
Contributor
Author
|
@yunzheng all done (AFAIK :) ) |
yunzheng
approved these changes
Dec 18, 2023
Member
yunzheng
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.