Fix bad envvar syntax in GitHub Action#2
Merged
Merged
Conversation
5441bda to
6866b80
Compare
Fix bad environment variable syntax on GitHub Action. The result of this incorrect syntax was the SLACK_TOKEN not being passed through correctly which led to HTTP status 400 on curl calls to the Slack Webhook API. This update fixes it. Also add a debug line to the slack-notify.sh script so that the on failure we can more easily find the command that caused the error.
juliaogris
added a commit
that referenced
this pull request
Jan 16, 2024
- Create major release from docs/releasenotes/v*.md
- Add GitHub release generation with `gh release create ...`
- Update hermit packages
This merges the following commits:
* hermit: Upgrade packages
* make: Create major release from docs/releasenotes/v*.md
* make: Add GitHub release generation
Makefile | 30 ++++++++++++++-----
bin/{.make-4.3.pkg => .gh-2.42.0.pkg} | 0
bin/{.shellcheck-0.7.1.pkg => .make-4.4.pkg} | 0
....shfmt-3.2.4.pkg => .shellcheck-0.9.0.pkg} | 0
bin/.shfmt-3.7.0.pkg | 1 +
bin/gh | 1 +
bin/make | 2 +-
bin/shellcheck | 2 +-
bin/shfmt | 2 +-
notes.txt | 3 ++
slack-notify.sh | 2 +-
11 files changed, 32 insertions(+), 11 deletions(-)
Pull-Request: #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bad environment variable syntax on GitHub Action. The result of this
incorrect syntax was the SLACK_TOKEN not being passed through correctly
which led to HTTP status 400 on curl calls to the Slack Webhook API.
This update fixes it.
Also add a debug line to the slack-notify.sh script so that the on
failure we can more easily find the command that caused the error.
Fix typo in picture base URL