Skip to content

fix: resolve page sales-taxes-and-charges not found err #50593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix: resolve page sales-taxes-and-charges not found err #50593

wants to merge 1 commit into from

Conversation

@ShreyasTheNewbie
Copy link
Contributor

@ShreyasTheNewbie ShreyasTheNewbie commented Nov 18, 2025

Updated the link_to field for the "Sales Template" sidebar item from "Sales Taxes and Charges" to "Sales Taxes and Charges Template" in erpnext/workspace_sidebar/taxes.json, since Sales Taxes and Charges is a child table.

no-docs

@ShreyasTheNewbie ShreyasTheNewbie marked this pull request as ready for review November 18, 2025 09:51
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 18, 2025

📝 Walkthrough

Walkthrough

The change updates a single configuration field in the taxes workspace sidebar JSON file. The link target for the first Workspace Sidebar Item is changed from "Sales Taxes and Charges" to "Sales Taxes and Charges Template". This is a targeted configuration update with no method additions, signature changes, or variable renames.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that "Sales Taxes and Charges Template" is a valid and existing DocType reference
  • Confirm the link target change aligns with intended workspace navigation behavior

Possibly related PRs

Suggested labels

skip-release-notes

Suggested reviewers

  • ruthra-kumar

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main change: fixing a 404 error by correcting the sidebar link from an incorrect page reference to the correct template page.
Description check ✅ Passed The description clearly explains why the change was made: the link was pointing to a child table instead of the correct template, with sufficient context about the file being modified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1be525 and fb60d6c.

📒 Files selected for processing (1)
  • erpnext/workspace_sidebar/taxes.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Summary
🔇 Additional comments (1)
erpnext/workspace_sidebar/taxes.json (1)

20-20: Correct link target for Sales Template sidebar item.

The change to point the "Sales Template" sidebar item to "Sales Taxes and Charges Template" is appropriate. This DocType is valid and actively used throughout the codebase—it's configured as a Link field option in Delivery Note, referenced in setup wizard operations for template creation, and already appears in the selling.json workspace sidebar. The change aligns with the established pattern used for the "Purchase Template" item (line 43).

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

mihir-kandoi
mihir-kandoi requested changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@mihir-kandoi mihir-kandoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not directly edit *.json files! Please edit the DocType using the Framework.

@ShreyasTheNewbie ShreyasTheNewbie marked this pull request as draft November 27, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihir-kandoi mihir-kandoi mihir-kandoi requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mihir-kandoi mihir-kandoi

@sokumon sokumon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShreyasTheNewbie @mihir-kandoi @sokumon