Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Aug 17, 2025

Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.

This PR contains the following updates:

Package Type Update Change
actions/checkout action major v4 -> v5

Release Notes

actions/checkout (actions/checkout)

v5

Compare Source


Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the renovate label Aug 17, 2025
@renovate renovate bot requested a review from a team as a code owner August 17, 2025 07:43
@renovate renovate bot requested review from StevenXL and removed request for a team August 17, 2025 07:43
@StevenXL
Copy link

StevenXL commented Sep 4, 2025

@pbrisbin this PR is failing because stack-action detects a file with the name stack-nightly.yml and then calls stack with --resolver nightly. This ignores the contents of stack-nightly.yml file. Is this expected behavior? If so, why have any content in stack-nightly.yml at all?

stack-action code: https://github.com/freckle/stack-action/blob/2e37b29addb79880b5fdfd22b48aa8fc07745f61/src/stack-cli.ts#L44-L49

@StevenXL StevenXL requested a review from pbrisbin September 4, 2025 20:14
@pbrisbin pbrisbin removed their request for review September 5, 2025 10:54
@pbrisbin
Copy link
Member

pbrisbin commented Sep 5, 2025

This ignores the contents of stack-nightly.yml file.

It's not ignoring the contents of stack-nightly.yaml, it's overriding the resolver. That's because resolver: nightly doesn't work -- you must use a concrete date. Therefore, we tend to put the date of the last time we've maintained the file, and then use --resolver nightly.

Is this expected behavior?

Yes, see above. The need for --resolver nightly is why stack-action does what it does.

If so, why have any content in stack-nightly.yml at all?

It's true that if resolver were the only thing in the file we could somehow make things work without it, but it's very rare you don't also need extra-deps or allower-new directives to get nightly compiling, which are not being ignored. Additionally, the presence of a file with this name is how stack-action knows what to do.

@StevenXL StevenXL enabled auto-merge (squash) September 19, 2025 20:32
Adds cryptonite-0.30 to extra-deps in stack-nightly.yaml to resolve
build failure. The stack nightly build was failing because yesod-auth
depends on cryptonite which wasn't available in the current snapshot.
@StevenXL StevenXL requested a review from pbrisbin September 24, 2025 16:22
@StevenXL
Copy link

cc @pbrisbin can you take a look; I had to make changes so I can't merge my own changes.

@pbrisbin pbrisbin requested review from pbrisbin and removed request for pbrisbin September 24, 2025 16:28
@StevenXL StevenXL merged commit 36bc61f into main Sep 24, 2025
13 checks passed
@StevenXL StevenXL deleted the renovate/actions-checkout-5.x branch September 24, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants