Wait for service calls to complete concurrently #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lambda bug in concurrent callbacks
a49026f to
4bbba79
Compare
Owner
|
@Skehmatics thanks for the contribution On paper, it sounds like a nice improvement. I've rebased it and added a few tweaks to it. I'll be running it for a few days at my home :) All going well, a new release will come out soon after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some configurations, a light's service call may take a moment to complete (50-500 ms). This is acceptable when controlling a single device, however if the lightener group is more than a handful of devices changing states can take multiple seconds!
To improve the experience when this is the case, this change makes each call a task and awaits them as a group before unlocking the lightener device. This improves the time it takes my rooms' lights to settle on the desired state from ~5 seconds to ~100ms.