Fix Process.enumerateModules() under x86(-64) arch.
#1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: frida/frida#3582; May be related? #392
In short, the rtld_db_dlactivity on x64 is shorter, only one byte.
Unfortunately, the interceptor has issues handling short functions; investigations suggest it requires at least 5 bytes.
I'm unsure if the interceptor‘s arm64 backend also has this problem. I disassembled the linker64 on the phone and found the function is 8 bytes long, potentially avoiding the issue.
The patch attempts to resolve the problem using the aligned bytes after the function; generally, overwriting them is safe.
Additionally, I added error logging to the
gum_hook_rtld_notifier; I believe errors shouldn't be ignored here, as they complicate troubleshooting.