Skip to content

Added get_device_by_id to the device_manager and example#117

Merged
s1341 merged 4 commits into
frida:mainfrom
ChaosRepeat:main
Dec 14, 2023
Merged

Added get_device_by_id to the device_manager and example#117
s1341 merged 4 commits into
frida:mainfrom
ChaosRepeat:main

Conversation

@stonecrumbler

Copy link
Copy Markdown
Contributor

Added a convenience method to get a device by its identifier. This is most useful if you have multiple USB or network devices attached and want to work with a specific one without having to enumerate all and find the one by id.

Created a simple example that demonstrates the usage of the get_device_by_type and get_device_by_id methods.

@s1341

s1341 commented Dec 13, 2023

Copy link
Copy Markdown
Contributor

@iteroji please see the CI error. The test cannot be run on CI.

@s1341 s1341 closed this Dec 13, 2023
@s1341 s1341 reopened this Dec 13, 2023
@stonecrumbler

Copy link
Copy Markdown
Contributor Author

@iteroji please see the CI error. The test cannot be run on CI.

I had invalid characters in rust doc causing doc test to fail. Updated it, now all tests should pass

@s1341

s1341 commented Dec 13, 2023

Copy link
Copy Markdown
Contributor

Needs a cargo fmt.

@s1341

s1341 commented Dec 13, 2023

Copy link
Copy Markdown
Contributor

And now clippy is complaining :(

@stonecrumbler

Copy link
Copy Markdown
Contributor Author

And now clippy is complaining :(

At least now I know what checks to run before PR :)

@s1341 s1341 merged commit a4482a2 into frida:main Dec 14, 2023
@s1341

s1341 commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants