Add get_remote_device#133
Merged
Merged
Conversation
s1341
reviewed
Jun 4, 2024
s1341
left a comment
Contributor
There was a problem hiding this comment.
Apologies for not getting to this till now. Looks good, except for the one comment.
| /// Returns the remote device with the specified host. | ||
| pub fn get_remote_device(&'a self, host: &str) -> Result<Device<'a>> { | ||
| let mut error: *mut frida_sys::GError = std::ptr::null_mut(); | ||
| let Ok(host_cstring) = CString::new(host) else { |
Contributor
There was a problem hiding this comment.
This should be:
let host_cstring = CString::new("message").map_err(|_| Error::CStringFailed)?;
Contributor
|
CI is failing.... |
s1341
approved these changes
Jul 11, 2024
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to rename the function or make any modifications