Skip to content

Remove Legacy Qt Build Option#62

Merged
ptsouchlos merged 2 commits into
fstl-app:masterfrom
jackie-scholl:raptortech-js-patch-1
Nov 4, 2020
Merged

Remove Legacy Qt Build Option#62
ptsouchlos merged 2 commits into
fstl-app:masterfrom
jackie-scholl:raptortech-js-patch-1

Conversation

@jackie-scholl

Copy link
Copy Markdown
Contributor

Master failed to build for me on NixOS; I tracked the issue down to axis.cpp not being built in the versions that had it, because it wasn't tracked in fstl.pro. I'm not entirely sure how it works to be honest, but at least for me, this patch gets it building.

This change fixes a build failure, at least on my system
@mboerwinkle

Copy link
Copy Markdown
Contributor

Cool. Should we also take this opportunity to add in vector.h (used by loader.cpp)? My intuition tells me yes, but I know almost nothing about qt .pro files. I just noticed it was missing too, and wanted to say something.
Thanks,
Martin

@ptsouchlos

Copy link
Copy Markdown
Member

Thanks for bringing this up. We haven't really been keeping the Qt creator build updated since CMake support was added. I can try to take a a look as well.

@jackie-scholl

jackie-scholl commented Nov 3, 2020

Copy link
Copy Markdown
Contributor Author

I can also experiment with moving nixpkgs to use a CMake-based build, if you think that's the better choice long-term

EDIT: I was able to get a CMake-based build working in nix, if you decide that CMake is the preferred build system then I'll submit a PR to nixpkgs. I do think it's worth deciding to either put the two build systems on equal footing and test them both on every PR, or deprecate one of them.

@ptsouchlos

Copy link
Copy Markdown
Member

Personally I think the CMake-based build is the best bet moving forward. I haven't used the Qt based build in some time and not sure if it's even needed anymore.

@mkeeter Any reason to keep the .pro file around anymore since we have a CMake based build now?

@mkeeter

mkeeter commented Nov 4, 2020

Copy link
Copy Markdown
Collaborator

Nope – CMake is definitely the wave of the future for Qt-based apps, so I'm fine removing the .pro file.

@ptsouchlos

Copy link
Copy Markdown
Member

@raptortech-js If you update the PR to remove the .pro file, I'll happily merge it in.

@jackie-scholl

Copy link
Copy Markdown
Contributor Author

@DeveloperPaul123 Done, thanks!

@ptsouchlos ptsouchlos changed the title Update fstl.pro to add axes Remove Legacy Qt Build Option Nov 4, 2020
@ptsouchlos ptsouchlos merged commit 5685aeb into fstl-app:master Nov 4, 2020
@ptsouchlos

Copy link
Copy Markdown
Member

Thanks @raptortech-js !

@jackie-scholl jackie-scholl deleted the raptortech-js-patch-1 branch November 4, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants