Feature/open external #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeveloperPaul123
requested changes
Jan 22, 2025
Member
DeveloperPaul123
left a comment
There was a problem hiding this comment.
Overall looks good and I'd be happy to merge this. Please convert tabs to spaces though (1 tab = 4 spaces for this project).
src/window.cpp
Outdated
| orthographic_action->setChecked(true); | ||
| } | ||
|
|
||
| QString path = settings.value(OPEN_EXTERNAL_KEY, "cura5").toString(); |
Member
There was a problem hiding this comment.
I would make the default be an empty string so the user has to set it if they intend to use this feature.
Contributor
Author
There was a problem hiding this comment.
Added a file dialog when the action is invoked with an empty string. If the user has selected a file it is stored in the .conf file and the ui is updated to reflect that.
Fixed indents Fixed indents Fixed indents
Member
explorer_2025-01-22_16-41-37.mp4Looks like it works well! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be useful for someone that wants to open they're viewing in a slicer for immediate printing.
Added a simple .conf file option to specify an external command or an absolute path to a program to open the current file with ALT+S shortcut.
Added a ~ expand to filename provided via command line arguments.