fix: add missing InterruptFlags field#6
Merged
Merged
Conversation
Owner
|
Thanks for the PR. This seems correct according to https://github.com/wowdev/WoWDBDefs/blob/58bea4ff45fa3655d5a59df0f2961bd25f39777b/definitions/Spell.dbd#L1337 as well. Could you update the PR by removing the wow_dbc/rxml/vanilla_xml/Spell.xml Line 795 in a5c27db wow_dbc/rxml/vanilla_xml/Spell.xml Line 329 in a5c27db cargo gen instead of changing the generated files directly? :)
|
The vanilla Spell.dbc has 173 uint32 fields per row. MaNGOS's SpellEntry (src/game/Server/DBCStructure.h) names field 21 as InterruptFlags, with AuraInterruptFlags at 22 and ChannelInterruptFlags at 23. The previous parser was missing InterruptFlags entirely and compensated with an `unknown_flag` field between spell_priority and the localized string block, keeping the total field count at 173 but causing every field from byte offset 84 onwards to be misaligned by one position: - `duration` was actually reading spellLevel - `power_type` was reading DurationIndex - `mana_cost` was reading powerType - the `effect[3]` array was reading EquippedItemInventoryTypeMask + Effect[0] + Effect[1], silently dropping Effect[2] - ...and so on through the rest of the row. Add `interrupt_flags: i32` between category_recovery_time and aura_interrupt_flags; remove the placeholder `unknown_flag` between spell_priority and the name string. Row size is unchanged.
Contributor
Author
|
Updated the Spell.xml and ran |
Owner
|
Thanks for the PR. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Claude:
(vibe coded from Claude Code - confirmed it fixed my aura duration issue though)