-
Notifications
You must be signed in to change notification settings - Fork 567
Add tag page experiment and pull storylines content #28463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Georges-GNM
wants to merge
5
commits into
main
Choose a base branch
from
gl/add-tag-page-supercharger-content
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
565483a to
5ab720c
Compare
fredex42
approved these changes
Dec 15, 2025
Contributor
fredex42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, put in a couple of suggestions for alternate names for the expieriment
| participationGroup = Perc0D, | ||
| ) | ||
|
|
||
| object AITagPageContent |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AIStorylines? TagPageAIStorylines ?
b58a392 to
fa73ec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Part of the AI tag page project - the tool uploads json content for the AI curated storylines to s3 with the required data for DCR to be able to render it.
On discussion with the WebEx and F&C teams, we agreed that frontend would be pulling this and passing it to DCR. So this PR implements that - we define the relevant classes and objects to be able to provide the StorylinesContent to the DotcomTagPagesRenderingModel.
This will be displayed during an AB test in January, so for the purposes of testing and development, we just set up a 0% experiment (ensuring this logic doesn’t get called unless opted in) without restricting which pages this can appear on. the plan is to just run them on two pages (though possibly slightly more, so still a bit tbd); a subsequent PR will add a check to make sure we’re only displaying this on the desired pages.
The relevant DCR PR is here.
Testing
Can best be tested with the DCR PR and checking the content appears on the desired page.
Checklist
data/databasefiles generated by tests are committed with this PR (the tests will fail in CI if you've forgotten to do this)