feat!: Lookup configPath in configFiles#128
Merged
Merged
Conversation
e74b54d to
9518999
Compare
Member
Author
|
@sttk please review, as this is some cleanup that I want to do before translations and themes. I believe that simplifying the env override will allow me to more easily implement your suggestions in my prototype. |
sttk
reviewed
Mar 13, 2024
Contributor
sttk
left a comment
There was a problem hiding this comment.
This change looks good. I have raised one point, but other than that, I think it's fine.
Contributor
|
Additionally, would it be acceptable to override |
Merged
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In gulp-cli, we seem to have a lot of confusing code to try to fallback to the
flags.gulpfiledefined in the.gulp.jsconfig file. Instead of all that code, we should just support it in liftoff.