Fix router test failures with two critical bug fixes#136
Merged
Conversation
1. **Operator precedence bug in isPartialWildcard**: Fixed incorrect boolean
operator precedence that was causing any string ending with '*' to be
considered a partial wildcard regardless of length requirement.
Changed: test.len >= 2 and test.startsWith('*') or test.endsWith('*')
To: test.len >= 2 and (test.startsWith('*') or test.endsWith('*'))
2. **Exception handling bug**: Fixed router exception handling that wasn't
properly catching AssertionDefect. The generic except: block doesn't catch
AssertionDefect in Nim, causing test failures when notFoundHandler called
doAssert false.
Changed: except: to except Exception as e:
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator precedence bug in isPartialWildcard: Fixed incorrect boolean operator precedence that was causing any string ending with '' to be considered a partial wildcard regardless of length requirement. Changed: test.len >= 2 and test.startsWith('') or test.endsWith('') To: test.len >= 2 and (test.startsWith('') or test.endsWith('*'))
Exception handling bug: Fixed router exception handling that wasn't properly catching AssertionDefect. The generic except: block doesn't catch AssertionDefect in Nim, causing test failures when notFoundHandler called doAssert false. Changed: except: to except Exception as e:
🤖 Generated with Claude Code