Prefer json tag over yaml:"-" when both are present#85
Open
okaris wants to merge 2 commits into
Open
Conversation
…tag for generation; fixes gzuidhof#54
Owner
|
Hi @okaris, Thank you for the contribution :) Could you make adapt the changes to only include the fix? (i.e. only the changes to |
Owner
|
It's been a while now, but would be happy to include this change if you could update the PR to remove the unrelated changes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54.
When both json and yaml tags are specified on a struct field, and the yaml tag is explicitly set to "-", the field should still be included in the TypeScript output using the json tag. This change prioritizes the json tag in such cases, ensuring that valid fields are not incorrectly omitted.