Skip to content

Conversation

@jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Jan 30, 2025

close #411

  • lots left to do, some farmed out to new issues
    • I made some decent progress in vrs/models.py but it's just an utter minefield so I opted to exclude it from linting entirely. It'd be nice to return at a later point but it's gonna take some real attention, particularly given the way that equivalent type annotations seem to have some runtime effects here.
    • Some other lint groups are blanket ignored for a couple of different files, mostly related to docstrings and type annotations for modules that I'm not particularly familiar with. It'd be good to make progress on them in the future.
    • Made a few specific issues about particular things that will entail minor runtime changes to correctly fix. Otherwise, every change made here should be more or less irrelevant for anything other than style
  • add to CICD/precommit
  • sort out circular import issue

open questions:

  • should the test action only run if lint passes?

@korikuzma
Copy link
Contributor

should the test action only run if lint passes?

Yes, following GenomicMedLab/software-templates#50

@jsstevenson
Copy link
Contributor Author

@jsstevenson jsstevenson marked this pull request as ready for review January 31, 2025 17:19
@jsstevenson jsstevenson requested review from a team as code owners January 31, 2025 17:19
@jsstevenson jsstevenson added the priority:medium Medium priority label Jan 31, 2025
Copy link
Contributor

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@jsstevenson jsstevenson merged commit 51f08c9 into main Jan 31, 2025
14 checks passed
@jsstevenson jsstevenson deleted the ruff branch January 31, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pylint/yapf -> ruff

3 participants