fix: use correct error message for ref vs actual ref #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Everything's passing with the exception of #560 |
korikuzma
reviewed
Jun 27, 2025
Contributor
There was a problem hiding this comment.
I think the original was correct, but maybe we could just revise the warning message?
Like "Input expression expected {ref} but the actual sequence on this position is {expected_ref}"?
Contributor
Author
There was a problem hiding this comment.
Yes, this PR is just modifying the message - it wasn't throwing an error incorrectly, the description of the error was backwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original message is a little ambiguous -- edited for clarity
eg