Fixed drop parameter#62
Merged
Merged
Conversation
* change from homemade gha scripts to biocthis gha workflow * install tinytex v2 and packages * include bioc devel test
c-mertes
added a commit
that referenced
this pull request
Feb 11, 2024
#63) This is a backport to release version `1.14.0` of #62. Fixes in this commit: * Set default for `drop` to `FALSE` in `[` generic function and ignore this argument * Extended testing to test for the `drop` argument. * fix GitHub Action again * update and align FRASER documentation * Update RoxyGen documentation to 7.3.1 * Add ORCID ids to DESCRIPTION * fixed BugReports in DESCRIPTION * remove CCX11 flags from Makevars --------- Co-authored-by: Christian Mertes <mertes@in.tum.de> Co-authored-by: Drew Behrens <drewjbeh@gmail.com>
c-mertes
added a commit
that referenced
this pull request
Feb 11, 2024
#62) Fixes in this commit: * Set default for `drop` to `FALSE` in `[` generic function and ignore this argument * Extended testing to test for the `drop` argument. * fix GitHub Action again * update and align FRASER documentation * Update RoxyGen documentation to 7.3.1 * Add ORCID ids to DESCRIPTION * fixed BugReports in DESCRIPTION * remove CCX11 flags from Makevars --------- Co-authored-by: Christian Mertes <mertes@in.tum.de> Co-authored-by: Drew Behrens <drewjbeh@gmail.com>
c-mertes
added a commit
that referenced
this pull request
Feb 11, 2024
#62) Fixes in this commit: * Set default for `drop` to `FALSE` in `[` generic function and ignore this argument * Extended testing to test for the `drop` argument. * fix GitHub Action again * update and align FRASER documentation * Update RoxyGen documentation to 7.3.1 * Add ORCID ids to DESCRIPTION * fixed BugReports in DESCRIPTION * remove CCX11 flags from Makevars --------- Co-authored-by: Christian Mertes <mertes@in.tum.de> Co-authored-by: Drew Behrens <drewjbeh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor changes to the generic in a much cleaer fix than before!