Skip to content

More robust recursion in Group.getAllChildren() #283

Description

@BenjaminDRichards

The current implementation is hard-locked to just check for Group, via objType()==="Group". This means it doesn't play well with extreme group derivatives, such as the forthcoming buffered rendering plugin. It would be better to check for children that implement getAllChildren() themselves.

Activity

  1. BenjaminDRichards commented on Nov 23, 2016

    @BenjaminDRichards
    ContributorAuthor

    Addendum thought: There's a possibility of getting infinite loops if the group derivative doesn't prevent such behavior. For example, buffers can form simple feedback loops, although they cannot self-feedback in a single step. We should at least point out that getAllChildren() implementations should self-avert in some fashion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions