Attempt to fix the interactive logger#2446
Closed
Lalshivam wants to merge 1 commit into
Closed
Conversation
Contributor
|
All of these things we want to keep as |
Member
|
Please avoid AI generated PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix was straightforward and involved two key changes:
Moved Finalisation Logs from INFO to DEBUG
The noisy shutdown/finalisation messages that were spamming the interactive console were changed from logger.info()
to logger.debug():
-Before (spammy in interactive mode)
log.info("Ganga is now attempting to shut down...")
-After (only visible in DEBUG mode)
log.debug("Ganga is now attempting to shut down...")
Why This Works:
-INFO level remains active in interactive mode (not globally suppressed)
-Important user messages still appear at INFO level
-Internal finalisation chatter is now at DEBUG level, only visible when debugging
-Users who need to see finalisation details can use --debug flag
This approach is cleaner than the previous workaround of suppressing all INFO logs globally, which broke legitimate INFO messages that users needed to see.