Sign Windows executables with SignPath#4056
Merged
Merged
Conversation
amolenaar
reviewed
Oct 9, 2025
Member
amolenaar
left a comment
There was a problem hiding this comment.
Nice. The changes look good (simple).
Co-authored-by: Arjan Molenaar <gaphor@gmail.com>
Member
|
btw. the windows executables script is trying to call |
amolenaar
approved these changes
Oct 12, 2025
Member
amolenaar
left a comment
There was a problem hiding this comment.
Looks really good. It's great SignPath is able to help out.
Member
Author
|
Since the release certificate is approved, I'm going to go ahead and merge this. |
Member
|
Thanks @danyeaw You want to roll a release as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves from using our own Windows certificates to sign our Windows executables to using SignPath to sign them for us.
The next step will be to contact SignPath to get the production certificates generated.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information