Skip to content

Added aloneguid/Storage backed blob event and snapshot store#93

Open
628426 wants to merge 1 commit into
gautema:masterfrom
628426:master
Open

Added aloneguid/Storage backed blob event and snapshot store#93
628426 wants to merge 1 commit into
gautema:masterfrom
628426:master

Conversation

@628426

@628426 628426 commented Jan 28, 2020

Copy link
Copy Markdown

Added BlobEventStore based on https://github.com/aloneguid/storage which should work with AWS, Amazon, Local File and a few other storage engines.

Similarly added BlobSnapshotStore.

@aloneguid any guidance on this implementation would be appreciated

@628426 628426 requested a review from gautema January 28, 2020 23:11
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ArveSystad

Copy link
Copy Markdown
Contributor

IMHO, this does not belong in a simple framework like this. It makes a lot of assumptions (even down to things like "does your connection string begin with azure"), and a lot of external dependencies. Could be made as a standalone package if anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants