Update Markdown formatting, global flags behavior#1
Conversation
`strings.Title` was deprecated in Go 1.18
- MD001 - Heading levels should only increment by one level at a time - https://github.com/DavidAnson/markdownlint/blob/v0.27.0/doc/md001.md
- MD040 - Fenced code blocks should have a language specified - https://github.com/DavidAnson/markdownlint/blob/v0.27.0/doc/md040.md
gavv
reviewed
Jan 27, 2023
gavv
left a comment
Owner
There was a problem hiding this comment.
Thanks for PR! Here are a few comments.
Owner
|
Thanks, LGTM! |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
text) for fenced code blocksstrings.Titlewithcases.Title, as the former was deprecated in Go 1.18Thank you for your work on this package! It is excellent for generating single pages of documentation for CLI's built with Cobra.
In the absence of a CONTRIBUTORS file, please let me know if I need to make any code changes to follow your coding conventions or if I need to create a matching issue for this changeset.