Sync Ionic and Jetty directories with Harmonic #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
iche033
reviewed
Jul 31, 2025
| files, but when problems arise the `--skip-keys` argument is used. Explanations | ||
| for its use in the previous line are given below: | ||
|
|
||
| * `gz-cmake3`: `gz-tools2` can build from source against |
Contributor
There was a problem hiding this comment.
update the gz package numbers for jetty?
Contributor
Author
There was a problem hiding this comment.
Updated in 222d098.
I'm verifying with Steve that we'll be using gz-tools3 in Jetty. If so, we won't need to skip the gz-cmake rosdep key, which is what I've updated the document to reflect.
Contributor
Author
There was a problem hiding this comment.
Okay, I've learned that we're still using gz-tools2 in Jetty, so I have updated it again in f3fa36e. The skip-keys is still on gz-cmake3 because that's what in the package.xml file in gz-tools2.
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
iche033
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gazebosim/gz-jetty#16
Summary
The most notable changes are in the ros2 integration tutorials which mostly landed in Harmonic, but were never synced to Ionic and Jetty.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.