Skip to content

Conversation

@azeey
Copy link
Contributor

@azeey azeey commented Aug 28, 2025

🦟 Bug fix

Fixes #607

Summary

This relies on the index.yaml file at the root of this repo to determine the version number if it can be obtained from the build directory names. It sets merge-multiple: false in the download action so that the downloaded artifact will have the directory structure as shown in the comments at the top of the file:

# api-docs-fortress
# ignition-utils1
# doxygen
# html
# ignition-math6
# doxygen
# html
# api-docs-harmonic
# gz-utils2
# doxygen
# html
# gz-math7
# doxygen
# html
# api-docs-jetty.
# gz-utils
# doxygen
# html
# gz-math
# doxygen
# html

I've also added proper argument parsing and functionality to test this locally by generating test files using the --gen-test-files flag.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey added 2 commits August 27, 2025 23:03
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Copy link
Contributor Author

azeey commented Aug 28, 2025

Running the API Doc generation job manually: https://github.com/gazebosim/docs/actions/runs/17285450094. This will do all the steps except deploy the generated docs.

@azeey
Copy link
Contributor Author

azeey commented Aug 28, 2025

Inspecting the generated archive (https://github.com/gazebosim/docs/actions/runs/17285450094/artifacts/3869862854), I think it's working properly:

├── cmake
│   ├── 2
│   │   └── index.html
│   ├── 3
│   │   └── index.html
│   ├── 4
│   │   └── index.html
│   └── 5
│       └── index.html
├── common
│   ├── 4
│   │   └── index.html
│   ├── 5
│   │   └── index.html
│   ├── 6
│   │   └── index.html
│   └── 7
│       └── index.html
├── fuel_tools
│   ├── 10
│   │   └── index.html
│   ├── 11
│   │   └── index.html
│   ├── 7
│   │   └── index.html
│   └── 9
│       └── index.html
├── gazebo
│   └── 6
│       └── index.html
├── gui
│   ├── 10
│   │   └── index.html
│   ├── 6
│   │   └── index.html
│   ├── 8
│   │   └── index.html
│   └── 9
│       └── index.html
├── launch
│   ├── 5
│   │   └── index.html
│   ├── 7
│   │   └── index.html
│   ├── 8
│   │   └── index.html
│   └── 9
│       └── index.html
├── math
│   ├── 6
│   │   └── index.html
│   ├── 7
│   │   └── index.html
│   ├── 8
│   │   └── index.html
│   └── 9
│       └── index.html
├── msgs
│   ├── 10
│   │   └── index.html
│   ├── 11
│   │   └── index.html
│   ├── 12
│   │   └── index.html
│   └── 8
│       └── index.html
├── physics
│   ├── 5
│   │   └── index.html
│   ├── 7
│   │   └── index.html
│   ├── 8
│   │   └── index.html
│   └── 9
│       └── index.html
├── plugin
│   ├── 1
│   │   └── index.html
│   ├── 2
│   │   └── index.html
│   ├── 3
│   │   └── index.html
│   └── 4
│       └── index.html
├── rendering
│   ├── 10
│   │   └── index.html
│   ├── 6
│   │   └── index.html
│   ├── 8
│   │   └── index.html
│   └── 9
│       └── index.html
├── sdformat
│   ├── 12
│   │   └── index.html
│   ├── 14
│   │   └── index.html
│   ├── 15
│   │   └── index.html
│   └── 16
│       └── index.html
├── sensors
│   ├── 10
│   │   └── index.html
│   ├── 6
│   │   └── index.html
│   ├── 8
│   │   └── index.html
│   └── 9
│       └── index.html
├── sim
│   ├── 10
│   │   └── index.html
│   ├── 6
│   │   └── index.html
│   ├── 8
│   │   └── index.html
│   └── 9
│       └── index.html
├── tools
│   ├── 1
│   │   └── index.html
│   └── 2
│       └── index.html
├── transport
│   ├── 11
│   │   └── index.html
│   ├── 13
│   │   └── index.html
│   ├── 14
│   │   └── index.html
│   └── 15
│       └── index.html
└── utils
    ├── 1
    │   └── index.html
    ├── 2
    │   └── index.html
    ├── 3
    │   └── index.html
    └── 4
        └── index.html

Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally!

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Aug 28, 2025
@azeey azeey merged commit c0278a9 into master Aug 28, 2025
10 checks passed
@azeey azeey deleted the fix_api_doc_gen_jetty branch August 28, 2025 20:12
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

API Docs generation is broken on Jetty with removal of major version numbers

3 participants