Conversation
| @@ -0,0 +1 @@ | |||
| This file makes sure that Github Pages doesn't process mdBook's output. | |||
There was a problem hiding this comment.
This file is not needed, it's sufficient to not enable github pages with jekyll in the repository setting and github pages will just serve the selected folder / branch
There was a problem hiding this comment.
It's automatically generated, and I'm not seeing a way to disable it.
|
@avivace How are we going to handle the custom styling of the boxes? Also, should we offer the current Pan Docs color scheme as a theme? (If yes, there are a lot of corollary questions.) |
|
Misc. changes to be made:
|
|
How should glossary entries be marked up? |
7c4ae40 to
dea7045
Compare
|
A preview is now live! Feedback is welcome. |
|
Note: to test CI, as well as to update the preview, I am now pushing to https://github.com/ISSOtm/pandocs/tree/master instead. |
|
I also consolidated the build and deploy CI workflows into a single one, so that the build's results can be immediately used. Deployment is skipped when not pushing, pushing to a branch that isn't |
|
Since this has a custom PDF export (via the browser), can we consider #57 fixed by this? |
|
Everything is done besides the glossary markup, but that still has to be added separately, so there's no point in blocking the rest of the improvements. I'm waiting on @mid-kid's discussion on #18, and any other feedback that may surface. If no opposition is brought up, then I will push the changes to this branch and merge them. |
|
Great work @ISSOtm . This is gorgeous. The Glossary markup is not a priority for the migration PR. It wasn't there before, it's not necessary to have it now before migrating, it could be secondary task after we migrate to the new rust-based pipeline. |
Nope, I think we already brought that up but we could've done that before too and the PDF exported by a print from the browser does not provide a decent table of contents, etc so that issue still stands. |
Well, it's a hack, but since we have control over the renderer, so I can either edit By the way, since we have a ToC for navigating to a page, and the pages themselves are small enough (except "SGB Functions", which probably needs to be split), should we consider #60 fixed? |
|
mdbook-latex is worth looking into; if we can't get it to work, its README links to other projects that look potentially useful. |
I agree on closing #60. For the PDF export, I still want to consider merging everything into a single MD/latex file and the render an actual PDF (and HTML, for the single page export) from there. |
|
For that, I think the renderer I just linked could do a good job. We should look into it after merging this PR to avoid scope creep, though. |
Why:
What's missing:
Fixes #289
Fixes #290
Fixes #7, since we're not using Vuepress anymore
Fixes #19 by virtue of using custom themes, though a custom "Pan Docs"/"Classic" theme could be added.
Fixes #58 due to an entirely different layout
Fixes #60