This repository was archived by the owner on Jun 6, 2025. It is now read-only.
Gh-3334: Fix Gremlin Reusing Accumulo Iterators #3335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3335 +/- ##
=============================================
- Coverage 68.01% 68.00% -0.01%
Complexity 2596 2596
=============================================
Files 955 954 -1
Lines 30564 30554 -10
Branches 3376 3375 -1
=============================================
- Hits 20787 20779 -8
+ Misses 8302 8301 -1
+ Partials 1475 1474 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
cn337131
previously approved these changes
Nov 19, 2024
p29876
previously approved these changes
Nov 19, 2024
The merge-base changed after approval.
6eda5f4 to
2375e1a
Compare
cn337131
previously approved these changes
Nov 20, 2024
p29876
previously approved these changes
Nov 20, 2024
|
p29876
approved these changes
Nov 21, 2024
cn337131
approved these changes
Nov 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves Gremlin away from reusing the raw iterator passed back from the operation to instead buffering to a set first before continuing hopefully increasing performance.
Related issue