462 window extend window and windowmanager components#463
Merged
rzaharia merged 7 commits intoApr 24, 2025
Conversation
6 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR extends window functionality and the window manager components by adding note management features and tracking window creation details. Key changes include:
- Adding note management commands (copy, edit, delete) and related UI elements in the internal window manager.
- Enhancing the Window and Application APIs to support creation process details and notes.
- Updating the examples and API headers to reflect these feature additions.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Examples/WindowManager/main.cpp | Adds example code for creating multiple windows with notes functionality. |
| AppCUI/src/Dialogs/WindowManager.cpp | Extends the internal window manager with new commands and UI elements for note management. |
| AppCUI/src/Controls/Window.cpp | Implements new methods to manage creation process details and window notes. |
| AppCUI/src/ControlContext.hpp | Introduces new members to store creation process and notes. |
| AppCUI/src/Application/Application.cpp | Updates window creation functions to capture creation process details. |
| AppCUI/include/AppCUI.hpp | Updates API declarations to support the new features. |
Files not reviewed (2)
- CMakeLists.txt: Language not supported
- Examples/WindowManager/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
AppCUI/src/Dialogs/WindowManager.cpp:35
- The variable name 'btnCloseDescendands' appears to be misspelled. It should likely be 'btnCloseDescendants' to reflect its purpose.
Reference<Button> btnGoTo, btnClose, btnCloseAll, btnCloseDescendands, btnCancel;
There was a problem hiding this comment.
Pull Request Overview
This PR extends the window and WindowManager components by introducing note operations (copy, edit, delete) along with propagating window creation process details. Key changes include updates to window note handling via new APIs in Window and Application modules, UI layout adjustments in the WindowManager dialog, and corresponding updates to Control Context and header API signatures.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Examples/WindowManager/main.cpp | Implements a new MyWin class with support for adding notes and demonstration of window creation. |
| AppCUI/src/Dialogs/WindowManager.cpp | Adds note operation functions and UI changes (splitter panels, updated TreeView) in the dialog. |
| AppCUI/src/Controls/Window.cpp | Introduces methods for creation process details and note management functions. |
| AppCUI/src/ControlContext.hpp | Extends the window control context with creation process and notes fields. |
| AppCUI/src/Application/Application.cpp | Updates AddWindow and GetCurrentWindow to incorporate the new creation process parameter. |
| AppCUI/include/AppCUI.hpp | Updates API signatures for AddWindow and exposes GetCurrentWindow. |
Files not reviewed (2)
- CMakeLists.txt: Language not supported
- Examples/WindowManager/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
AppCUI/src/Dialogs/WindowManager.cpp:329
- The variable 'btnCloseDescendands' is misspelled; consider renaming it to 'btnCloseDescendants' for clarity and consistency.
CHECK((btnCloseDescendands = Factory::Button::Create(this, "Close &desc", "l:29,b:0,w:13", BUTTON_ID_CLOSE_DESC))
gheorghitamutu
approved these changes
Apr 24, 2025
116a496 to
4c7ebdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.