Miscelaneous improvements#369
Merged
Merged
Conversation
rzaharia
commented
Apr 28, 2025
Collaborator
- added XML plugin
- improved VBA with VBA plugins for constant variable replacement and concatenation
- updated AppCUI to have a reason for creating new Windows
- added reason for most windows upon creation
- added new decoding methods: HexCharacters, VBSDecoding, XORDecoding
…now pluigns can link the new window to the actual parent
There was a problem hiding this comment.
Pull Request Overview
This PR introduces several miscellaneous improvements including new XML and VBA plugins, updated window creation with an additional creationProcess parameter, and new decoding methods (HexCharacters, VBSEncoding, XOREncoding). Additionally, the PR refactors UI commands to support note additions and modernizes file and folder window creation across the application.
Reviewed Changes
Copilot reviewed 65 out of 68 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| GViewCore/src/include/Internal.hpp | Added new command/keyboard control for adding notes & overload updates with a creationProcess parameter. |
| GViewCore/src/View/TextViewer/Instance.cpp | Implemented selection validation and error messages for copy operations. |
| GViewCore/src/View/LexicalViewer/* | Updated PluginDialog and instance creation to support parent window refactoring. |
| GViewCore/src/View/BufferViewer/Instance.cpp | Adjusted key event handling and removed a duplicate key press case. |
| GViewCore/src/Decoding/* | Added new decoding methods for XOR, VBS, Hex and HTML with minor logic adjustments. |
| GViewCore/src/App/* | Refactored file/buffer window creation to include the creationProcess parameter and integrated the new note addition feature. |
| GViewCore/include/GView.hpp | Updated namespace function prototypes and added ListIterator helpers. |
| GView/src/GView.cpp | Updated ProcessOpenCommand to call OpenFile with a default creationProcess string. |
Files not reviewed (3)
- AppCUI: Language not supported
- CMakeLists.txt: Language not supported
- GViewCore/src/Decoding/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
GViewCore/src/Decoding/HTMLCharactersEncoding.cpp:47
- Using '&it->second' takes the address of the std::string object rather than its character buffer. Instead, use 'it->second.c_str()' to correctly create a string_view of its content.
output.Add(string_view(&it->second, 1));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.