Skip to content

barista version bump to 0.4.0 for PATCH, nested optional routes, new par...#612

Open
kieran wants to merge 1 commit into
geddy:masterfrom
kieran:master
Open

barista version bump to 0.4.0 for PATCH, nested optional routes, new par...#612
kieran wants to merge 1 commit into
geddy:masterfrom
kieran:master

Conversation

@kieran
Copy link
Copy Markdown
Contributor

@kieran kieran commented Jun 15, 2014

...ser

...sorry for the push to the wrong remote repo :-(

@mde
Copy link
Copy Markdown
Contributor

mde commented Jun 15, 2014

Looks like this breaks the build. Any idea off the top of your head what might not be backward compatible?

@kieran
Copy link
Copy Markdown
Contributor Author

kieran commented Jun 15, 2014

looks like a templating issue - probably inherited from a previous commit?

@mde
Copy link
Copy Markdown
Contributor

mde commented Jun 16, 2014

That's the application smoke test we do for each of the different templating engines. It generates a basic app for each one, then hits each of them with a few requests. I'm pretty sure this failure is due to the router change. The CI should run in all branches as well, so it's easy to dump large changes into feature branches and watch the CI.

I should mention we've been having issues with Node 0.8 in the tests. I don't think the NPM backend service works at all with 0.8-circa clients. If your tests work in 0.10, you're good to go.

@kieran
Copy link
Copy Markdown
Contributor Author

kieran commented Jun 16, 2014

hmm, seems to be an issue with the router helper generation in lib/template/helpers/action.js - fixed part of it but it's still bombing on something. Will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants