Add Hermitian matrices #1593

YannCabanes · 2022-06-22T21:43:21Z

No description provided.

codecov · 2022-06-22T22:41:59Z

Codecov Report

Merging #1593 (cfaa570) into master (fbe17c7) will decrease coverage by 12.16%.
The diff coverage is 86.67%.

@@             Coverage Diff             @@
##           master    #1593       +/-   ##
===========================================
- Coverage   92.06%   79.90%   -12.15%     
===========================================
  Files         115      115               
  Lines       11124    11621      +497     
===========================================
- Hits        10240     9285      -955     
- Misses        884     2336     +1452

Flag	Coverage Δ
autograd	`?`
numpy	`?`
pytorch	`79.90% <86.67%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
geomstats/_backend/__init__.py	`82.26% <ø> (ø)`
geomstats/geometry/hyperboloid.py	`84.55% <0.00%> (ø)`
geomstats/geometry/matrices.py	`97.24% <ø> (ø)`
geomstats/geometry/poincare_ball.py	`93.39% <ø> (ø)`
geomstats/geometry/poincare_half_space.py	`97.62% <ø> (ø)`
geomstats/geometry/poincare_polydisk.py	`90.91% <ø> (ø)`
geomstats/geometry/riemannian_metric.py	`76.82% <18.19%> (-20.06%)`	⬇️
geomstats/information_geometry/base.py	`52.64% <52.64%> (ø)`
geomstats/distributions/lognormal.py	`87.84% <66.67%> (ø)`
geomstats/geometry/euclidean.py	`91.90% <66.67%> (-2.22%)`	⬇️
... and 92 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…tensorflow backends

YannCabanes · 2022-06-27T22:04:48Z

Hello @ninamiolane and @LPereira95,
Could you help me with this PR please?
What should I change to pass the autograd, pytorch and tensorflow tests?

luisfpereira

Thanks @YannCabanes.

My review does not address yet your question about the reason for the tests to be failing for torch and tensorflow, but it brings some discussions I think are important to have.

I think the feedback from @ninamiolane and @nguigs will be important here due to the first time use of complex types.

geomstats/geometry/base.py

geomstats/geometry/matrices.py

geomstats/geometry/hermitian_matrices.py

geomstats/_backend/pytorch/__init__.py

geomstats/_backend/tensorflow/__init__.py

YannCabanes · 2022-06-30T05:56:59Z

Hello @LPereira95, @ninamiolane and @nguigs,
Could you help me by reviewing this PR dealing with complex numbers please?

… SPDXXXMetric

YannCabanes · 2022-10-11T15:05:16Z

Hello @LPereira95 and @ninamiolane,
Could you help me to try to merge this PR before the hackathon please?

Skip unit-tests that are failing too often (Stiefel, Gamma, Dirichlet)

Rename: OpenSet's ambient_space -> embedding_space & SPDMetricXXX -> SPDXXXMetric

Add curvature tensors - Follow-up from PR geomstats#1606

ninamiolane

LGTM! Two remarks:

is_floating should be renamed is_float
some tests are failing because of the recent addition of curvatures in geomstats, which do not work on these complex manifolds. You should skip these tests:
with:

    skip_test_covariant_riemann_tensor_is_skew_symmetric_1 = True
    skip_test_covariant_riemann_tensor_is_skew_symmetric_2 = True
    skip_test_covariant_riemann_tensor_bianchi_identity = True
    skip_test_covariant_riemann_tensor_is_interchange_symmetric = True
    skip_test_riemann_tensor_shape = True
    skip_test_scalar_curvature_shape = True
    skip_test_ricci_tensor_shape = True
    skip_test_sectional_curvature_shape = True

ninamiolane · 2022-10-17T07:53:30Z

geomstats/_backend/autograd/__init__.py

+    get_default_cdtype,
    get_default_dtype,
+    is_complex,
+    is_floating,


Why is floating? Change to is_float

ninamiolane · 2022-10-17T07:53:51Z

geomstats/_backend/autograd/_dtype.py



-def _is_floating(x):
+def is_floating(x):


ditto: change to is_float

ninamiolane · 2022-10-17T07:54:22Z

geomstats/_backend/numpy/__init__.py

+    get_default_cdtype,
    get_default_dtype,
+    is_complex,
+    is_floating,


ditto: is_float

ninamiolane · 2022-10-17T07:54:36Z

geomstats/_backend/numpy/_dtype.py



-def _is_floating(x):
+def is_floating(x):


Ditto: is_float

ninamiolane · 2022-10-17T07:54:52Z

geomstats/_backend/pytorch/__init__.py

 std = _preserve_input_dtype(_add_default_dtype_by_casting(target=_torch.std))


+def is_floating(x):


ditto: change to is_float

ninamiolane · 2022-10-17T07:55:28Z

geomstats/_backend/tensorflow/__init__.py

+    get_default_cdtype,
    get_default_dtype,
+    is_complex,
+    is_floating,


ditto: is_float

ninamiolane · 2022-10-17T07:55:43Z

geomstats/_backend/tensorflow/_dtype.py



-def _is_floating(x):
+def is_floating(x):


ninamiolane · 2022-10-17T07:55:51Z

geomstats/_backend/tensorflow/_dtype.py

 set_default_dtype = _pre_set_default_dtype(as_dtype)

-_cast_out_from_dtype = _pre_cast_out_from_dtype(_tf.cast, _is_floating, _is_complex)
+_cast_out_from_dtype = _pre_cast_out_from_dtype(_tf.cast, is_floating, is_complex)


…tats into add-hermitian-matrices

review-notebook-app · 2022-10-17T08:13:17Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

YannCabanes · 2022-10-17T08:28:08Z

Thank you @ninamiolane and @LPereira95 for helping me for this PR!
Is it finally ready to be merged now are should I still do some modifications ?
(You can push on my branch if more modifications are needed.)

YannCabanes · 2022-10-17T09:02:51Z

@ninamiolane, there is a problem with TensorFlow unit tests: AttributeError: 'DType' object has no attribute 'is_float'

YannCabanes added 4 commits June 22, 2022 13:15

Add Hermitian matrices

91a9d0f

Fix problems related to complex dtype

261888b

Fix docstring error.

ee1104d

Add complex to autograd

858d711

YannCabanes added 4 commits June 24, 2022 12:39

Fix pytorch and tensorflow backends errors

f36b189

Fix tests errors related to complex numbers in autograd, pytorch and …

41e53d8

…tensorflow backends

Remove commented lines

9d32de6

Remove useless addition sign in tensorflow backend

7f933eb

Fix error in condition formulation

123a841

luisfpereira self-requested a review June 28, 2022 08:25

luisfpereira requested changes Jun 28, 2022

View reviewed changes

julesofthefields and others added 2 commits June 29, 2022 16:35

curvature methods for connection

97fe1b3

Create complex_matrices.py

fb88da6

julesofthefields and others added 14 commits June 30, 2022 11:57

update on connection

12da0e2

Add ComplexMatricesMetric

2ecae63

Add belongs method to ComplexMatrices

e06b58d

Correct function name

ad9130b

Add tests for ComplexMatrices

4c622ce

Remove print in ComplexMatrices

76e3063

Use gs.logical_and is ComplexMatrices belongs method

0f72d24

Improve tests for ComplexMatrices and develop the class itself

4d04b8e

Remove commented lines in ComplexMatrices

3cfe47e

Modify inputs of super in ComplexMatrices

12ac044

Add blank line in if condition

80e9684

Correct error about HermitianMatrices dimension

fc0437a

curvature tensors

fa46e5a

Fix type error in tensorflow backend in tril and triu functions

b5f5095

YannCabanes and others added 5 commits October 9, 2022 23:58

Adapt tensorflow linalg norm function to possible complex inputs vectors

02a4b53

Add tests for ComplexRiemannianMetric

4b20093

Rename OpenSet's ambient space in embedding space + SPDMetricXXX into…

5978b9a

… SPDXXXMetric

Skip tests that are failing too often

68cd163

Correct typo

c5b2589

ninamiolane and others added 15 commits October 12, 2022 09:16

Fix skips that were not put in the right class

d55dede

Rename PSDMetricEuclidean -> PSDEuclideanMetric

9b64308

Merge pull request geomstats#1672 from ninamiolane/skip-tests

86f68c7

Skip unit-tests that are failing too often (Stiefel, Gamma, Dirichlet)

Debug MDM

b91e4cc

Change testing with class names to testing with class themseelves

90183ec

Merge pull request geomstats#1671 from ninamiolane/rename

f637e13

Rename: OpenSet's ambient_space -> embedding_space & SPDMetricXXX -> SPDXXXMetric

Address cde review comments

347ba0a

Merge branch 'master' into Jules-connection

28592c3

Add tests

1234789

Merge pull request geomstats#1668 from ninamiolane/Jules-connection

9e5d2ab

Add curvature tensors - Follow-up from PR geomstats#1606

Improve tests inheritance

3aee8c6

Add attributes in ComplexMatricesTestData

f5a003e

Add connection_args_list argument in ComplexMatricesTestData

b3ce650

Correct error in connection_args_list definition

4e68ce3

Add connection_args_list argument in ComplexRiemannianMetricTestData

44f77ef

ninamiolane approved these changes Oct 17, 2022

View reviewed changes

ninamiolane added 2 commits October 17, 2022 10:07

Merge branch 'add-hermitian-matrices' of github.com:YannCabanes/geoms…

257c334

…tats into add-hermitian-matrices

Add skip tests + change is_flaot

cfaa570

ninamiolane marked this pull request as ready for review October 17, 2022 08:13

ninamiolane closed this Oct 17, 2022

YannCabanes deleted the add-hermitian-matrices branch November 17, 2022 06:47

		std = _preserve_input_dtype(_add_default_dtype_by_casting(target=_torch.std))


		def is_floating(x):

Add Hermitian matrices #1593

Add Hermitian matrices #1593

Uh oh!

Conversation

YannCabanes commented Jun 22, 2022

Uh oh!

codecov bot commented Jun 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

YannCabanes commented Jun 27, 2022

Uh oh!

luisfpereira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YannCabanes commented Jun 30, 2022

Uh oh!

YannCabanes commented Oct 11, 2022

Uh oh!

ninamiolane left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

review-notebook-app bot commented Oct 17, 2022

Uh oh!

YannCabanes commented Oct 17, 2022

Uh oh!

YannCabanes commented Oct 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jun 22, 2022 •

edited

Loading