Search statistics / Move from database to elasticsearch and kibana #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore a number of issues/features in search statistics.
039c770 to
5170397
Compare
josegar74
reviewed
Jun 14, 2017
| client = ApplicationContextHolder.get().getBean(EsClient.class); | ||
| client.bulkRequest(index, listOfDocumentsToIndex); | ||
| } catch (JsonProcessingException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
A general comment, instead of printStackTrace would be better to use the logger to log the exception to avoid unwanted information disclosure.
josegar74
reviewed
Jun 14, 2017
| } catch (JsonProcessingException e) { | ||
| e.printStackTrace(); | ||
| return false; | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
Only JsonProcessingException and IOException are catch. Can happen other exceptions and if so should be catched to avoid if any error in ES indexing affects the current feature in GeoNetwork?
…database due to process ignoring excluded terms.
|
Replaced by #2082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Main goal of this proposal is to restore and improve search statistics. Currently search statistics have some limitations:
This work will also help on the future migration from Lucene to Elasticsearch.
It will also reduce a lot the size of the database by removing "requests" and "params" tables.
Proposal
In the admin console, Kibana is used to render the dashboard:
By default, 2 dashboards are provided:
... but user can create new dashboard and add them to the tab list by JS configuration: