Skip to content

Conversation

@fxprunayre
Copy link
Member

Relates to #4390 which
makes the CSW GetCapabilities configuration now done in a service
metadata record. The CswCapabilitiesInfo was unused. So removing it.

Replace that table by a translations table which can contains a list of
translations that can be manage through the API.

image

In a number of
situation, catalogue administrator wants to update client application
translation. This will be even more true in version 4 where you can for
example configure facet from the admin. When adding a facet,
corresponding labels will have to be added for the client side to render
properly labels. Those translations can be stored in this table and the
client side will load them. It could also be used to overrides some
default translation if this is something to support.

Relates to geonetwork#4390 which
makes the CSW GetCapabilities configuration now done in a service
metadata record. The CswCapabilitiesInfo was unused. So removing it.

Replace that table by a translations table which can contains a list of
translations that can be manage through the API. In a number of
situation, catalogue administrator wants to update client application
translation. This will be even more true in version 4 where you can for
example configure facet from the admin. When adding a facet,
corresponding labels will have to be added for the client side to render
properly labels. Those translations can be stored in this table and the
client side will load them. It could also be used to overrides some
default translation if this is something to support.
@fxprunayre fxprunayre requested a review from josegar74 June 12, 2020 07:33
@josegar74
Copy link
Member

Some questions about the API:

  • In the PUT request, it's a bit unclear what is the key and the content to send that seem a json document, is that a json with "langcode":"translation" entries?:

  • Does it override any translation defined in any of the json translation files (for the search, editor and admin apps?

  • What is the replace parameter used for?

  • Using the Swagger page the request (even if logged as Administrator) always is returning 201 response

@fxprunayre
Copy link
Member Author

  • In the PUT request, it's a bit unclear what is the key and the content to send that seem a json document, is that a json with "langcode":"translation" entries?:

Yes see https://github.com/geonetwork/core-geonetwork/pull/4756/files#diff-efacf5b847f05688c3b46e5a4373645eR71

Does it override any translation defined in any of the json translation files (for the search, editor and admin apps?

No. I expect to work on that on version 4 mainly for the facet config.

What is the replace parameter used for?

Remove all before. So you can make a partial update, only one language, or replace everything

@fxprunayre
Copy link
Member Author

Will only applied to v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants