-
-
Notifications
You must be signed in to change notification settings - Fork 501
Patch for ticket #973 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ianwallen
wants to merge
1
commit into
geonetwork:2.8.x
from
ianwallen:8c8f1119b8834e3e513aaed3f9d5d3fc9c9d90da
Closed
Patch for ticket #973 #6
ianwallen
wants to merge
1
commit into
geonetwork:2.8.x
from
ianwallen:8c8f1119b8834e3e513aaed3f9d5d3fc9c9d90da
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etj
referenced
this pull request
in geosolutions-it/core-geonetwork
Jan 22, 2013
Delawen
pushed a commit
to Delawen/core-geonetwork
that referenced
this pull request
Nov 27, 2013
Update to master
fxprunayre
referenced
this pull request
in fxprunayre/core-geonetwork
Jan 13, 2014
Align branch to develop
julian1
referenced
this pull request
in aodn/core-geonetwork
Jul 22, 2014
Hide the permalink-div when viewer is destroyed or hidden
fgravin
added a commit
that referenced
this pull request
Dec 4, 2014
Fixing regexp for layer type extraction from context
pvgenuchten
pushed a commit
to pvgenuchten/core-geonetwork
that referenced
this pull request
Nov 28, 2017
…anels Improve map panels
fxprunayre
added a commit
that referenced
this pull request
Dec 7, 2017
* If a layer is already in the map, warn user that it is the case and switch to the map viewer (currently, silently stop) * If the service URL is wrong or does not respond, inform user * If a layer is available with more than one representation type, * propose the list in the import panel * allow user to change the style, once the layer added to the map * Once a layer is added, allows user to easily zoom to it using a notification link * Make distinction between a service URL with a layer name and only a service URL * Improve error display and add link to failed tiles so user can try and see tile load error message by clicking the link * When click add layer and only a service URL is set, switch to the mapviewer > add layer from service and set the service URL to make the GetCapabilities request and list available layers (instead of trying to add a layer with no name) * Result view button : display description or name or url * Always define the mandatory STYLES parameter. ESRI is more strict than others on that. Even STYLES without equal return an error which is probably wrong (this needs to be solved on ESRI side probably). For the time being set the STYLES parameter to empty if no STYLES choosen: ``` <ServiceException code="StylesNotDefined">Parameter 'styles' is required.</ServiceException> ``` Squashed commit of the following: commit 7415113 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Wed Dec 6 09:07:28 2017 +0100 Add missing mandatory STYLES. Improve error messages. commit 9fe45d5 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 19:46:07 2017 +0100 Viewer improvements * Use gnViewerService when possible * Fix watch on getOpenedTool * Fix viewer service tab init to match the real GN app * Suggest user to zoom to the added layer * Related directive use the same addToMap function than search results commit 73f2192 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 19:42:39 2017 +0100 Related directive / Make distinction between a service link and a service+layer link. commit 598dc5d Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 19:41:43 2017 +0100 Add possibility to increase notification delay. commit 73509ee Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 17:45:25 2017 +0100 Click on layer title show/hide layer. commit 17d2dec Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 17:30:50 2017 +0100 Show style selector only for children. commit d5fff3b Merge: aa1f53d 3f59778 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 17:10:48 2017 +0100 Merge remote-tracking branch 'fxprunayre/improvement/map-layer-styles-and-errors' into improvement/map-layer-styles-and-errors commit aa1f53d Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 17:03:41 2017 +0100 Remove layer popup in case layer is removed. commit b639d11 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 13:12:31 2017 +0100 Display legend or attribution when available. Update legend URL on style change. commit 609e34d Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 09:13:41 2017 +0100 Map / Add layer / Style may be null. commit 4a8e9b7 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Sun Nov 12 09:24:53 2017 +0100 Map viewer / Improve the add layer to map process #2289 - Improvements. commit 836032f Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Fri Nov 10 09:29:31 2017 +0100 Map viewer / Improve the add layer to map process #2289 * If a layer is already in the map, warn user that it is the case and switch to the map viewer (currently, silently stop) * If the service URL is wrong or does not respond, inform user * If a layer is available with more than one representation type, propose the list in the import panel * allow user to change the style, once the layer added to the map commit 3f59778 Merge: aad4756 a329386 Author: François Prunayre <fx.prunayre@gmail.com> Date: Tue Nov 21 14:31:39 2017 +0100 Merge pull request #6 from MichelGabriel/3.4.x-improve-mappanels Improve map panels commit a329386 Merge: bd3736b aad4756 Author: Michel Gabriël <michel.gabriel@geocat.net> Date: Thu Nov 16 15:49:21 2017 +0100 Merge branch 'improvement/map-layer-styles-and-errors' into 3.4.x-improve-mappanels commit bd3736b Author: Michel Gabriel <michel.gabriel@geocat.net> Date: Thu Nov 16 11:27:52 2017 +0100 Changes to the manage layer drop down: * added whitespace * added borders * added 2 titles commit 028d6ad Author: Michel Gabriel <michel.gabriel@geocat.net> Date: Thu Nov 16 10:18:32 2017 +0100 Better outlining the text in the styles popover commit 46999f0 Author: Michel Gabriel <michel.gabriel@geocat.net> Date: Thu Nov 16 10:18:00 2017 +0100 Add the `add to map` button * add button as last element in an list item * no `add to map` title on the layer commit aad4756 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 13:12:31 2017 +0100 Display legend or attribution when available. Update legend URL on style change. commit 7ae29fa Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 09:13:41 2017 +0100 Map / Add layer / Style may be null. commit 9a0f0da Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Sun Nov 12 09:24:53 2017 +0100 Map viewer / Improve the add layer to map process #2289 - Improvements. commit 945771f Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Fri Nov 10 09:29:31 2017 +0100 Map viewer / Improve the add layer to map process #2289 * If a layer is already in the map, warn user that it is the case and switch to the map viewer (currently, silently stop) * If the service URL is wrong or does not respond, inform user * If a layer is available with more than one representation type, propose the list in the import panel * allow user to change the style, once the layer added to the map commit da29201 Author: Michel Gabriel <michel.gabriel@geocat.net> Date: Wed Nov 15 13:43:12 2017 +0100 Improvements to the `add layer panel` * new `add to map` button * max height for lists of layers * reset button to clear list and url * less whitespace in `services` tab commit 2c24ea3 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 13:12:31 2017 +0100 Display legend or attribution when available. Update legend URL on style change. commit 3532aee Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 09:13:41 2017 +0100 Map / Add layer / Style may be null. commit 6bde95d Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Sun Nov 12 09:24:53 2017 +0100 Map viewer / Improve the add layer to map process #2289 - Improvements. commit 4b65e5c Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Fri Nov 10 09:29:31 2017 +0100 Map viewer / Improve the add layer to map process #2289 * If a layer is already in the map, warn user that it is the case and switch to the map viewer (currently, silently stop) * If the service URL is wrong or does not respond, inform user * If a layer is available with more than one representation type, propose the list in the import panel * allow user to change the style, once the layer added to the map Avoid error if no metadata. If layer not in capability suggest user to load another one.
pvgenuchten
pushed a commit
to pvgenuchten/core-geonetwork
that referenced
this pull request
Dec 12, 2017
* If a layer is already in the map, warn user that it is the case and switch to the map viewer (currently, silently stop) * If the service URL is wrong or does not respond, inform user * If a layer is available with more than one representation type, * propose the list in the import panel * allow user to change the style, once the layer added to the map * Once a layer is added, allows user to easily zoom to it using a notification link * Make distinction between a service URL with a layer name and only a service URL * Improve error display and add link to failed tiles so user can try and see tile load error message by clicking the link * When click add layer and only a service URL is set, switch to the mapviewer > add layer from service and set the service URL to make the GetCapabilities request and list available layers (instead of trying to add a layer with no name) * Result view button : display description or name or url * Always define the mandatory STYLES parameter. ESRI is more strict than others on that. Even STYLES without equal return an error which is probably wrong (this needs to be solved on ESRI side probably). For the time being set the STYLES parameter to empty if no STYLES choosen: ``` <ServiceException code="StylesNotDefined">Parameter 'styles' is required.</ServiceException> ``` Squashed commit of the following: commit 7415113 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Wed Dec 6 09:07:28 2017 +0100 Add missing mandatory STYLES. Improve error messages. commit 9fe45d5 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 19:46:07 2017 +0100 Viewer improvements * Use gnViewerService when possible * Fix watch on getOpenedTool * Fix viewer service tab init to match the real GN app * Suggest user to zoom to the added layer * Related directive use the same addToMap function than search results commit 73f2192 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 19:42:39 2017 +0100 Related directive / Make distinction between a service link and a service+layer link. commit 598dc5d Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 19:41:43 2017 +0100 Add possibility to increase notification delay. commit 73509ee Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 17:45:25 2017 +0100 Click on layer title show/hide layer. commit 17d2dec Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 17:30:50 2017 +0100 Show style selector only for children. commit d5fff3b Merge: aa1f53d 3f59778 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 17:10:48 2017 +0100 Merge remote-tracking branch 'fxprunayre/improvement/map-layer-styles-and-errors' into improvement/map-layer-styles-and-errors commit aa1f53d Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Tue Dec 5 17:03:41 2017 +0100 Remove layer popup in case layer is removed. commit b639d11 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 13:12:31 2017 +0100 Display legend or attribution when available. Update legend URL on style change. commit 609e34d Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 09:13:41 2017 +0100 Map / Add layer / Style may be null. commit 4a8e9b7 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Sun Nov 12 09:24:53 2017 +0100 Map viewer / Improve the add layer to map process geonetwork#2289 - Improvements. commit 836032f Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Fri Nov 10 09:29:31 2017 +0100 Map viewer / Improve the add layer to map process geonetwork#2289 * If a layer is already in the map, warn user that it is the case and switch to the map viewer (currently, silently stop) * If the service URL is wrong or does not respond, inform user * If a layer is available with more than one representation type, propose the list in the import panel * allow user to change the style, once the layer added to the map commit 3f59778 Merge: aad4756 a329386 Author: François Prunayre <fx.prunayre@gmail.com> Date: Tue Nov 21 14:31:39 2017 +0100 Merge pull request geonetwork#6 from MichelGabriel/3.4.x-improve-mappanels Improve map panels commit a329386 Merge: bd3736b aad4756 Author: Michel Gabriël <michel.gabriel@geocat.net> Date: Thu Nov 16 15:49:21 2017 +0100 Merge branch 'improvement/map-layer-styles-and-errors' into 3.4.x-improve-mappanels commit bd3736b Author: Michel Gabriel <michel.gabriel@geocat.net> Date: Thu Nov 16 11:27:52 2017 +0100 Changes to the manage layer drop down: * added whitespace * added borders * added 2 titles commit 028d6ad Author: Michel Gabriel <michel.gabriel@geocat.net> Date: Thu Nov 16 10:18:32 2017 +0100 Better outlining the text in the styles popover commit 46999f0 Author: Michel Gabriel <michel.gabriel@geocat.net> Date: Thu Nov 16 10:18:00 2017 +0100 Add the `add to map` button * add button as last element in an list item * no `add to map` title on the layer commit aad4756 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 13:12:31 2017 +0100 Display legend or attribution when available. Update legend URL on style change. commit 7ae29fa Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 09:13:41 2017 +0100 Map / Add layer / Style may be null. commit 9a0f0da Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Sun Nov 12 09:24:53 2017 +0100 Map viewer / Improve the add layer to map process geonetwork#2289 - Improvements. commit 945771f Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Fri Nov 10 09:29:31 2017 +0100 Map viewer / Improve the add layer to map process geonetwork#2289 * If a layer is already in the map, warn user that it is the case and switch to the map viewer (currently, silently stop) * If the service URL is wrong or does not respond, inform user * If a layer is available with more than one representation type, propose the list in the import panel * allow user to change the style, once the layer added to the map commit da29201 Author: Michel Gabriel <michel.gabriel@geocat.net> Date: Wed Nov 15 13:43:12 2017 +0100 Improvements to the `add layer panel` * new `add to map` button * max height for lists of layers * reset button to clear list and url * less whitespace in `services` tab commit 2c24ea3 Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 13:12:31 2017 +0100 Display legend or attribution when available. Update legend URL on style change. commit 3532aee Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Mon Nov 13 09:13:41 2017 +0100 Map / Add layer / Style may be null. commit 6bde95d Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Sun Nov 12 09:24:53 2017 +0100 Map viewer / Improve the add layer to map process geonetwork#2289 - Improvements. commit 4b65e5c Author: Francois Prunayre <fx.prunayre@gmail.com> Date: Fri Nov 10 09:29:31 2017 +0100 Map viewer / Improve the add layer to map process geonetwork#2289 * If a layer is already in the map, warn user that it is the case and switch to the map viewer (currently, silently stop) * If the service URL is wrong or does not respond, inform user * If a layer is available with more than one representation type, propose the list in the import panel * allow user to change the style, once the layer added to the map Avoid error if no metadata. If layer not in capability suggest user to load another one.
juanluisrp
pushed a commit
to juanluisrp/core-geonetwork
that referenced
this pull request
Oct 25, 2019
hide and auto complete quality/resurstyp
MichelGabriel
referenced
this pull request
in MichelGabriel/core-geonetwork
Nov 24, 2020
Add Content statictics link
cmangeat
pushed a commit
to cmangeat/core-geonetwork
that referenced
this pull request
Jun 27, 2021
fxprunayre
pushed a commit
that referenced
this pull request
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.