Skip to content

Conversation

@joachimnielandt
Copy link
Contributor

@joachimnielandt joachimnielandt commented Nov 3, 2025

After merging 4.4.9 we noticed an issue in our download dropdown where all download urls are missing. This can be "fixed" by adding the debug flag in the url, which lead me to believe this is some asynchronous behaviour. After debugging, md is not initialised at the moment of loading the available formatters, when the issue occurs. I have moved the function call to the $watch function, ensuring md is present when needed.

Is this the right approach? Or should the directive only load when md is present, deprecating the need to null check the variable?

Before
image

After
image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant