Fetch formatters only when md has loaded #9091
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging 4.4.9 we noticed an issue in our download dropdown where all download urls are missing. This can be "fixed" by adding the
debugflag in the url, which lead me to believe this is some asynchronous behaviour. After debugging,mdis not initialised at the moment of loading the available formatters, when the issue occurs. I have moved the function call to the $watch function, ensuring md is present when needed.Is this the right approach? Or should the directive only load when
mdis present, deprecating the need to null check the variable?Before

After

Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation