Skip to content

BGDIDIC-1069: remove links to pdf files #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
faselm merged 2 commits into from
Dec 3, 2025
Merged

BGDIDIC-1069: remove links to pdf files #4752

faselm merged 2 commits into from
Dec 3, 2025

Conversation

@faselm
Copy link
Contributor

@faselm faselm commented Nov 20, 2025

No description provided.

@github-actions github-actions bot added the data-integration This issue/pr is related to data integration work label Nov 20, 2025
@github-actions github-actions bot added this to the 2025-12-17 milestone Nov 20, 2025
ltclm
ltclm requested changes Nov 20, 2025
View reviewed changes
chsdi/templates/htmlpopup/babs_kulturgueter.mako Outdated
lang = lang if lang in ('fr','it') else 'de'
import os
Copy link
Contributor

@ltclm ltclm Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to import os?

Copy link
Contributor Author

@faselm faselm Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested without the import and it seems not! Thanks for pointing this out, I removed it

@faselm faselm requested a review from ltclm November 20, 2025 10:08
@faselm faselm merged commit 1f30f09 into develop-2025-12-17 Dec 3, 2025
5 checks passed
@faselm faselm deleted the data-BGDIDIC-1069-kulturgueter branch December 3, 2025 07:34
@faselm
Copy link
Contributor Author

faselm commented Dec 3, 2025

This is strange, this pr had no error before the merge. It has been merged, but the changes weren't taken into account on dev with an error in the unittest-ci log about test_helpers and test_resource_exist function.

======================================================================
FAIL: test_resource_exists (tests.functional.test_helpers.TestHelpers.test_resource_exists)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/codebuild/output/src75/src/github.com/geoadmin/mf-chsdi3/tests/functional/test_helpers.py", line 37, in test_resource_exists
    self.assertTrue(test_result)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^
AssertionError: False is not true
-------------------- >> begin captured logging << --------------------
nose2.loader: DEBUG: loadTestsFromName tests.functional.test_helpers.TestHelpers.test_resource_exists/None
nose2.plugins.loader.discovery: DEBUG: _find_tests('tests.functional.test_helpers.TestHelpers.test_resource_exists', '/codebuild/output/src75/src/github.com/geoadmin/mf-chsdi3')
nose2.plugins.loader.testcases: DEBUG: load tests.functional.test_helpers.TestHelpers.test_resource_exists from None
urllib3.connectionpool: DEBUG: Starting new HTTPS connection (1): api3.geo.admin.ch:443
urllib3.connectionpool: DEBUG: https://api3.geo.admin.ch:443 "HEAD / HTTP/1.1" 302 0
nose2.plugins.mp: DEBUG: Received results for tests.functional.test_helpers.TestHelpers.test_resource_exists
nose2.plugins.mp: DEBUG: Received startTest(StartTestEvent(handled=False, test='tests.functional.test_helpers.TestHelpers.test_resource_exists', result=None, startTime=1764747771.2794037))
nose2.plugins.mp: DEBUG: Received setTestOutcome(TestOutcomeEvent(handled=False, test='tests.functional.test_helpers.TestHelpers.test_resource_exists', result=None, outcome='failed', exc_info=(<class 'AssertionError'>, AssertionError('False is not true'), 'Traceback (most recent call last):\n  File "/codebuild/output/src75/src/github.com/geoadmin/mf-chsdi3/tests/functional/test_helpers.py", line 37, in test_resource_exists\n    self.assertTrue(test_result)\n    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^\nAssertionError: False is not true\n'), reason=None, expected=False, shortLabel=None, longLabel=None))
--------------------- >> end captured logging << ---------------------
----------------------------------------------------------------------
Ran 53 tests in 0.843s
FAILED (failures=1)
make: *** [Makefile:349: unittest-ci] Error 1

@ltclm
Copy link
Contributor

ltclm commented Dec 3, 2025

@faselm this has been fixed in another branch which is already in the milestone branch, please rebase.

faselm added a commit that referenced this pull request Dec 3, 2025
@faselm
Revert "Merge pull request #4752 from geoadmin/data-BGDIDIC-1069-kult…
8e12f6a 
…urgueter"

This reverts commit 1f30f09, reversing
changes made to 4458e0a.
@faselm faselm mentioned this pull request Dec 3, 2025
Merged
faselm added a commit that referenced this pull request Dec 3, 2025
@faselm
Merge pull request #4762 from geoadmin/data-BGDIDIC-1069-kulturgueter…
26e2120 
…-revert

Revert "Merge pull request #4752 from geoadmin/data-BGDIDIC-1069-kult…
ltclm pushed a commit that referenced this pull request Dec 15, 2025
@faselm @ltclm
Merge pull request #4752 from geoadmin/data-BGDIDIC-1069-kulturgueter
35de34e 
BGDIDIC-1069: remove links to pdf files
ltclm pushed a commit that referenced this pull request Dec 15, 2025
@faselm @ltclm
Revert "Merge pull request #4752 from geoadmin/data-BGDIDIC-1069-kult…
1dd303f 
…urgueter"

This reverts commit 1f30f09, reversing
changes made to 4458e0a.
ltclm pushed a commit that referenced this pull request Dec 15, 2025
@faselm @ltclm
Merge pull request #4762 from geoadmin/data-BGDIDIC-1069-kulturgueter…
7b83893 
…-revert

Revert "Merge pull request #4752 from geoadmin/data-BGDIDIC-1069-kult…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ltclm ltclm ltclm approved these changes

@marionb marionb Awaiting requested review from marionb

@rebert rebert Awaiting requested review from rebert

@belisas belisas Awaiting requested review from belisas

@julianhafner julianhafner Awaiting requested review from julianhafner

Assignees

No one assigned

Labels

data-integration This issue/pr is related to data integration work

Projects

None yet

Milestone

2025-12-17

Development

Successfully merging this pull request may close these issues.

3 participants

@faselm @ltclm