Handle rexml dependency in Ruby 3.0 #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
approved these changes
Jun 16, 2021
Contributor
olleolleolle
left a comment
There was a problem hiding this comment.
This is a quite tight and informative change!
Member
|
Thanks, @trevorturk, not only for your contribution here but also for all the provided context. I think we can use this approach at the moment and see how the gem evolves, dropping the support to old Ruby versions soon. |
dsantosmerino
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in Ruby 3.0, many gems are now "bundled gems" which are not required by default. [1] [2]
After trying a few things (details) and chatting with @olleolleolle, I adjusted this PR to only require
rexmlif we're parsing xml, and then rescue the possibleLoadErrorwith alogger.errormessage before re-raising. The simplest fix, really, is for Ruby 3.0 users to addrexmlto theirGemfileso this should point the way.