Skip to content

Conversation

@KostyaEsmukov
Copy link
Member

Add new geocoders tests for checking that:

  • All geocoders are exported and have expected __all__ values.
  • All required params in __init__, geocode/reverse/reverse_timezone methods are present in the signatures and have expected defaults.
  • All params are documented with :param ...: directives.
  • No unexpected public methods are introduced.

This should highlight interface errors early before a PR review when a new geocoder class is introduced.

@KostyaEsmukov KostyaEsmukov added this to the 2.2 milestone Mar 28, 2021
@KostyaEsmukov KostyaEsmukov force-pushed the add-geocoder-signature-tests branch from 602c083 to 25f1bdc Compare March 28, 2021 15:13
@KostyaEsmukov KostyaEsmukov force-pushed the add-geocoder-signature-tests branch from 25f1bdc to 50630dc Compare April 3, 2021 21:38
@KostyaEsmukov KostyaEsmukov merged commit 8eb2c82 into master Apr 3, 2021
This was referenced Apr 3, 2021
@KostyaEsmukov KostyaEsmukov deleted the add-geocoder-signature-tests branch April 3, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants